Support building via nix #4821
Merged
Support building via nix #4821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #10195: Bundle Size — 62.34MiB (+0.02%).
Warning Bundle contains 66 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #10195 report View feature/nix-docker-build-2 branch activity View project dashboard |
Rheeseyb
changed the title
Rheeseyb
requested review from
gbalint,
seanparsons,
ruggi,
balazsbajorics,
liady and
bkrmendy
|
Performance test results: |
ruggi
approved these changes
Feb 2, 2024
seanparsons
reviewed
Feb 2, 2024
shell.nix
Outdated
|
|
||
| expectedToolVersions :: [(String, [String], [String])] | ||
| expectedToolVersions = | ||
| [ ("pnpm", ["--version"], ["7.14.2"]) |
There was a problem hiding this comment.
Should we add nodejs to this?
There was a problem hiding this comment.
Yeah, that's not a bad shout
seanparsons
reviewed
Feb 2, 2024
balazsbajorics
approved these changes
Feb 2, 2024
seanparsons
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We use nix for local development, but a series of scripts to build and deploy the actual project, leading to discrepancies between both environments that tend to cause painful issues when they arise. This has become more important now that we want to be able to use separate nix packages for building vscode vs the rest of the editor, so that we can support different node versions.
Fix:
This PR introduces the required scripts to be able to build and deploy the application using nix exclusively. It also introduces a new
vscode-build/shell.nixfor building vscode with a different version of node.Note:
As part of this I also upped the node version to v18 for the rest of the editor. I'm happy to drop that back down to v16 and introduce that change in a separate PR.