Follow based on connection id, disallow chained follows #4762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4761
Problem:
Right now it's not possible to follow self on different tabs, because the follow logic only takes the player ID into account.
Also, we should not allow chained follows.
Fix:
Include the connection ID into the follow logic calculations, and keep it in the editor mode. Also, simplify the
canFollowTarget
logic so that it only allows direct follows and prevent from following users that are already following another user.