Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow based on connection id, disallow chained follows #4762

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Jan 18, 2024

Fix #4761

Problem:

Right now it's not possible to follow self on different tabs, because the follow logic only takes the player ID into account.
Also, we should not allow chained follows.

Fix:

Include the connection ID into the follow logic calculations, and keep it in the editor mode. Also, simplify the canFollowTarget logic so that it only allows direct follows and prevent from following users that are already following another user.

@ruggi ruggi changed the title follow based on connection id, disallow chained follows Follow based on connection id, disallow chained follows Jan 18, 2024
Copy link
Contributor

github-actions bot commented Jan 18, 2024

Try me

Copy link

relativeci bot commented Jan 18, 2024

Job #9956: Bundle Size — 62.33MiB (~+0.01%).

86ed505(current) vs 8f5e3ac master#9955(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #9956
     Baseline
Job #9955
Regression  Initial JS 45.52MiB(~+0.01%) 45.52MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 20% 19.88%
No change  Chunks 26 26
No change  Assets 30 30
No change  Modules 4392 4392
No change  Duplicate Modules 474 474
No change  Duplicate Code 30.74% 30.74%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #9956
     Baseline
Job #9955
Regression  JS 62.32MiB (~+0.01%) 62.32MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #9956 reportView feat/follow-target-conn-id branch activityView project dashboard

Copy link
Contributor

Performance test results:
(Chart1)
(Chart2)

@ruggi ruggi merged commit 041d49b into master Jan 18, 2024
15 checks passed
@ruggi ruggi deleted the feat/follow-target-conn-id branch January 18, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow following per-connection, disallow chained follows
3 participants