Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects link in settings #4663

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Projects link in settings #4663

merged 4 commits into from
Dec 15, 2023

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Dec 15, 2023

Fix #4662

Problem:

The user bar avatar for the self one is a link to /projects, which is inconsistent.

Fix:

  • Remove the link from the user bar
  • Add a new link in the Settings tab
Screenshot 2023-12-15 at 1 40 09 PM

Copy link
Contributor

github-actions bot commented Dec 15, 2023

Try me

Copy link

relativeci bot commented Dec 15, 2023

Job #9631: Bundle Size — 62.08MiB (-2.48%).

7e4b85e(current) vs df0030c master#9618(baseline)

Important

Bundle introduced 6 and removed 15 duplicate packages – View changed duplicate packages

Warning

Bundle introduced one new package: @ampproject/remapping – View changed packages

Bundle metrics  Change 9 changes Regression 1 regression Improvement 4 improvements
                 Current
Job #9631
     Baseline
Job #9618
Improvement  Initial JS 45.29MiB(-2.45%) 46.43MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 91.96% 20.52%
Change  Chunks 26(-3.7%) 27
Change  Assets 30(-3.23%) 31
Change  Modules 4357(-3.16%) 4499
Improvement  Duplicate Modules 468(-0.64%) 471
Regression  Duplicate Code 30.71%(+0.16%) 30.66%
Improvement  Packages 462(-2.12%) 472
Improvement  Duplicate Packages 65(-13.33%) 75
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
Job #9631
     Baseline
Job #9618
Improvement  JS 62.07MiB (-2.48%) 63.65MiB
Improvement  HTML 11.53KiB (-0.02%) 11.54KiB

View job #9631 reportView feat/settings-projects-link branch activity

Copy link
Contributor

github-actions bot commented Dec 15, 2023

Performance test results:
(Chart1)
(Chart2)

Copy link
Member

@maltenuhn maltenuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel just about competent enough to review this :)

@ruggi ruggi merged commit d916c49 into master Dec 15, 2023
13 checks passed
@ruggi ruggi deleted the feat/settings-projects-link branch December 15, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projects link in settings not user bar
3 participants