Don't switch to comment mode on indicator drag #4641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruggi
changed the title
Job #9565: Bundle Size — 63.63MiB (~-0.01%).
Warning Bundle contains 78 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #9565 report View fix/dont-open-comments-drag branch activity |
|
Performance test results: |
bkrmendy
approved these changes
Dec 12, 2023
Rheeseyb
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4640
Problem:
When dragging a comment indicator, the editor switches to comment mode and auto-opens the popup for the dragged comment.
Fix:
Instead, dragging the comment only updates the thread metadata (= position), with the possible mode switch and popup being triggered only on actual click events.