Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix elements outside area indicator showing up when it should not #6366

Closed
ruggi opened this issue Sep 13, 2024 · 0 comments · Fixed by #6367
Closed

fix elements outside area indicator showing up when it should not #6366

ruggi opened this issue Sep 13, 2024 · 0 comments · Fixed by #6367
Assignees
@ruggi

Comments

@ruggi
Copy link
Contributor

ruggi commented Sep 13, 2024

No description provided.

@ruggi ruggi self-assigned this Sep 13, 2024
@ruggi ruggi mentioned this issue Sep 13, 2024
Merged
ruggi added a commit that referenced this issue Sep 13, 2024
@ruggi
Fix stubborn elements outside visible area indicator arrow (#6367)
a4ac2e4 
**Problem:**

The elements outside visible area indicator arrow sometimes shows up
even when the element is obviously inside the visible area.

**Fix:**

Use the fresh metadata to detect the elements outside visible area,
because otherwise the frame data might be stale on certain interactions
(e.g. insertion).

Also, simplified the code by removing some pre-cursor-positioning code
that was not relevant anymore.

| Before | After |
|---------|-----------|
| ![Kapture 2024-09-13 at 14 23
17](https://github.com/user-attachments/assets/0e9af6f4-7522-4461-a776-ca92cf6aaf21)
| ![Kapture 2024-09-13 at 14 24
03](https://github.com/user-attachments/assets/4a8d9d69-2682-4ae2-b82b-a8d6e8ed8005)
|

Fixes #6366
liady pushed a commit that referenced this issue Dec 13, 2024
@ruggi @liady
Fix stubborn elements outside visible area indicator arrow (#6367)
af3bc31 
**Problem:**

The elements outside visible area indicator arrow sometimes shows up
even when the element is obviously inside the visible area.

**Fix:**

Use the fresh metadata to detect the elements outside visible area,
because otherwise the frame data might be stale on certain interactions
(e.g. insertion).

Also, simplified the code by removing some pre-cursor-positioning code
that was not relevant anymore.

| Before | After |
|---------|-----------|
| ![Kapture 2024-09-13 at 14 23
17](https://github.com/user-attachments/assets/0e9af6f4-7522-4461-a776-ca92cf6aaf21)
| ![Kapture 2024-09-13 at 14 24
03](https://github.com/user-attachments/assets/4a8d9d69-2682-4ae2-b82b-a8d6e8ed8005)
|

Fixes #6366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruggi ruggi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix stubborn elements outside visible area indicator arrow concrete-utopia/utopia
1 participant
@ruggi