-
Notifications
You must be signed in to change notification settings - Fork 171
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Tailwind border-radius support (#6657)
**Problem:** Make border-radius controls work in tailwind projects. **Fix:** - Add the border-radius shorthand/longhand props to the StyleInfo interface - Add overflow prop to the StyleInfo interface (necessary because when we set the border-radius we set the element to overflow: hidden) - Update InlineStylePlugin and TailwindStylePlugin to support the new props in StyleInfo - Refactor the set-border-radius strategy and the border-radius control handle control to read element styles through a StyleInfoReader instance - Add a new property patcher in style-plugins@patchers to take care of patching removed border-radius props - Add a new EditorState substate so we can get a StyleInfoReader in a useEditorState hook without using the full store - Remove the condition in tailwind-compilation that `ElementsToRerenderGLOBAL.current` has to be `'rerender-all-elements'` for the tailwind classes to be regenerated. For some reason this blocked the class generation after a border-radius interaction. We are still protected against tailwind class generation during the interaction (we check `isInteractionActive`) - Add tests with a tailwind project to the set-border-radius strategy test suite - removeTailwindClasses guarantees that subsequent tests do not have the tailwind css on **Todo:** - [x] Check why the ``ElementsToRerenderGLOBAL.current` check caused problems. **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Play mode
- Loading branch information
Showing
12 changed files
with
514 additions
and
84 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.