Merge pull request #116 from areller/skip-not-uploaded-assets

skip not uploaded assets
concourse · Jun 8, 2022 · f963eb9 · f963eb9
2 parents 9a3c7fb + d8d46fe
commit f963eb9
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/in_command.go b/in_command.go
@@ -116,6 +116,11 @@ func (c *InCommand) Run(destDir string, request InRequest) (InResponse, error) {
 	}
 
 	for _, asset := range assets {
+		state := asset.State
+		if state == nil || *state != "uploaded" {
+			continue
+		}
+
 		path := filepath.Join(destDir, *asset.Name)
 
 		var matchFound bool

diff --git a/in_command_test.go b/in_command_test.go
@@ -83,9 +83,20 @@ var _ = Describe("In Command", func() {
 	}
 
 	buildAsset := func(id int64, name string) *github.ReleaseAsset {
+		state := "uploaded"
 		return &github.ReleaseAsset{
-			ID:   github.Int64(id),
-			Name: &name,
+			ID:    github.Int64(id),
+			Name:  &name,
+			State: &state,
+		}
+	}
+
+	buildFailedAsset := func(id int64, name string) *github.ReleaseAsset {
+		state := "starter"
+		return &github.ReleaseAsset{
+			ID:    github.Int64(id),
+			Name:  &name,
+			State: &state,
 		}
 	}
 
@@ -99,6 +110,7 @@ var _ = Describe("In Command", func() {
 					buildAsset(0, "example.txt"),
 					buildAsset(1, "example.rtf"),
 					buildAsset(2, "example.wtf"),
+					buildFailedAsset(3, "example.doc"),
 				}, nil)
 
 				inRequest.Version = &resource.Version{
@@ -402,6 +414,7 @@ var _ = Describe("In Command", func() {
 					Ω(githubClient.DownloadReleaseAssetArgsForCall(0)).Should(Equal(*buildAsset(0, "example.txt")))
 					Ω(githubClient.DownloadReleaseAssetArgsForCall(1)).Should(Equal(*buildAsset(1, "example.rtf")))
 					Ω(githubClient.DownloadReleaseAssetArgsForCall(2)).Should(Equal(*buildAsset(2, "example.wtf")))
+					Ω(githubClient.DownloadReleaseAssetCallCount()).Should(Equal(3))
 				})
 			})