Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change the "userIDFieldPerConnector" parameter's place #346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pedrodsrodrigues
Copy link

Why do we need this PR?

The concourse-chart/templates/web-deployment.yaml file is looking for Values.concourse.web.auth.userIDFieldPerConnector but the parameter is in concourse.web.auth.mainTeam.userIDFieldPerConnector, according to the documentation.

Changes proposed in this pull request

  • Change the parameter userIDFieldPerConnector to the correct place, which is concourse.web.auth.userIDFieldPerConnector instead of concourse.web.auth.mainTeam.userIDFieldPerConnector (or the opposite, if that's what is decided. But in that case it shouldn't go to the master branch).

Contributor Checklist

  • Variables are documented in the README.md
  • Which branch are you merging into?
    • master is for changes related to the current release of the concourse/concourse:latest image and should be good to publish immediately
    • dev is for changes related to the next release of Concourse (aka unpublished code on master in concourse/concourse)

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not
fill out this section.

  • Code reviewed
  • Topgun tests run
  • Back-port if needed
  • Is the correct branch targeted? (master or dev)

- Change the parameter "userIDFieldPerConnector" to the correct place
(it's the one currently working at least),
which is "concourse.web.auth.userIDFieldPerConnector"
instead of "concourse.web.auth.mainTeam.userIDFieldPerConnector".
- Add the parameter "concourse.web.auth.userIDFieldPerConnector"
to the table.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant