Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch readme errors #321

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

gartov
Copy link

@gartov gartov commented Jan 27, 2023

Existing Issue

Fixes # .

Why do we need this PR?

Changes proposed in this pull request

Contributor Checklist

  • Which branch are you merging into? -- into "master"
    • master is for changes related to the current release of the concourse/concourse:latest image and should be good to publish immediately
    • dev is for changes related to the next release of Concourse (aka unpublished code on master in concourse/concourse)

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not
fill out this section.

  • Code reviewed
  • Topgun tests run
  • Back-port if needed
  • Is the correct branch targeted? (master or dev)

Clean up language around how Concourse reads some values directly from secrets. These arguments do not have to be explicitly passed into Concourse.
Add 'local-userssecret example. Needed to which secret should contain thelocal-users` data.
Fixed name of setting example, from "class" to "storageClass"

Clean up language around how Concourse reads some values directly from secrets. These arguments do not have to be explicitly passed into Concourse.
Add 'local-users` secret example. Needed to which secret should contain the `local-users` data.
@xtremerui
Copy link
Contributor

Hi could you rebase, fix the DCO status check error and maby adding a bit of description of the change? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants