Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on poi libs version #25

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Conversation

tiagotcsilva
Copy link

The poi libs version were very outdated causing conflict problems with other project dependencies.

@nigelcharman
Copy link
Member

@robmoffat are you happy for us to pull and release these changes?

@robmoffat
Copy link
Member

Hi @nigelcharman,

Seeing some failures on the GitHub actions - is it worth trying to fix these first?

@tiagotcsilva
Copy link
Author

Just to add some information, i used jdk17 and everything worked nicely

@robmoffat
Copy link
Member

Hi @tiagotcsilva,
do you want to have a go at fixing the actions? Feel free to move to a newer JDK - I expect concordion has a minimum JDK number they’re supporting, though.

I’ll run the actions for you if you comment again on this PR. I’m away from my desk but I’ll see the email. Cheers

@tiagotcsilva
Copy link
Author

Hi @robmoffat i just upgraded gradle version to 8.5, removed jdk 1.8 compilation and added jdk17.

I executed the actions on my fork and it seems ok.

@robmoffat robmoffat merged commit d550f0a into concordion:master Dec 21, 2023
3 of 4 checks passed
@nigelcharman
Copy link
Member

@tiagotcsilva thanks for making these changes. It looks like we'll need to make a few changes to the publishing mechanism to release it. Are you OK to wait until after the new year for an official release?

@tiagotcsilva
Copy link
Author

@nigelcharman it's ok, no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants