Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent panic on thread if no mount is selected #47

Merged
merged 3 commits into from
Jul 1, 2023

Conversation

HenryRoutson
Copy link

@HenryRoutson HenryRoutson commented Jul 1, 2023

Just a simple fix
You can see the bug if you try to search before selecting a drive,
the drive is set to "" and an unwrap none panics a thread

something like

thread 'tokio-runtime-worker' panicked at 'called Option::unwrap() on a None value', src/search.rs:88:59
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
thread 'tokio-runtime-worker' panicked at 'called Result::unwrap() on an Err value: PoisonError { .. }', src/search.rs:85:34
thread 'notify-rs fsevents loop' panicked at 'called Result::unwrap() on an Err value: PoisonError { .. }', src/filesystem/cache.rs:48:48

I think this should be set to all mounts or the 0th by defualt, and outlined in the ui somehow

@conaticus

i think this may fix part of #26

@conaticus
Copy link
Owner

Thanks, I moved this to the client side and sent an alert if search was attempted outside of volume.
Also haven't forgot about #39, will test soon

@conaticus conaticus merged commit aea2d11 into conaticus:dev Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants