Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#282 Add CONAN_REMOVE_OUTDATE_PACKAGES option #353

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

#282 Add CONAN_REMOVE_OUTDATE_PACKAGES option #353

wants to merge 11 commits into from

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Mar 15, 2019 •
edited
Loading

The new option will run conan remove <ref> -r <remote> -f --outdated after to upload a package.

Changelog: Feature: Remove outdated package after to upload (#282)

closes #282

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.

@uilianries
conan-io#282 Add CONAN_REMOVE_OUTDATE_PACKAGES option
2a95fc6 
- The new option will run conan remove <ref> -r <remote> -f --outdated
  after to upload a package

Signed-off-by: Uilian Ries <[email protected]>
@uilianries uilianries requested review from SSE4 and lasote March 15, 2019 21:27
@uilianries
Copy link
Member Author

All conflicts have been solved!

@uilianries uilianries added this to the 0.25.0 milestone Mar 19, 2019
@lasote lasote removed this from the 0.25.0 milestone Mar 20, 2019
lasote
lasote suggested changes Oct 29, 2019
View reviewed changes
cpt/test/test_client/erase_checks_test.py Outdated Show resolved Hide resolved
@uilianries
Update parametrized requirement
8664ebf 
- nose_parametrized is deprecated and has been replaced by parametrized

Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Validate when remove is false
f9deb22 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Fix env vars
279c44f 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Copy link
Member Author

Ops! It's incompatible with Conan-dev branch:

AttributeError: 'ConanFileLoader' object has no attribute 'load_class'

@uilianries
Copy link
Member Author

@lasote I've mixed this PR with a fix to support Conan 1.20.0-dev. The load_class method was removed from Conan API.

@lasote
Copy link
Contributor

lasote commented Oct 30, 2019

Please, extract the fix for the Conan 1.20 to another branch, I'm not sure about this feature, to be honest.

@uilianries
Copy link
Member Author

Please, extract the fix for the Conan 1.20 to another branch, I'm not sure about this feature, to be honest.

Done: #419

@Croydon
Copy link
Contributor

Croydon commented Nov 22, 2020

I think this is still a feature worth considering, what do you all think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasote lasote lasote requested changes

@SSE4 SSE4 Awaiting requested review from SSE4

Assignees

@lasote lasote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove outdated package after to upload
3 participants
@uilianries @lasote @Croydon