replxx: fix MinGW shared + remove old version + fix cpp_info.libs for RelWithDebInfo #20566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ld.exe: CMakeFiles/replxx-example-cxx-api.dir/examples/cxx-api.cxx.obj:cxx-api.cxx:(.text+0x17e1): undefined reference to 'replxx::color::bold(replxx::Replxx::Color)'
. Actually all the export logic for Windows was a little bit messy.I still need to test these patches (submitted upstream Fix export/import of DLL symbols AmokHuginnsson/replxx#151), but I'm not on Windows currently.
cpp_info.libs
if build_typeRelWithDebInfo
, there is a-rd
suffix: https://github.com/AmokHuginnsson/replxx/blob/release-0.0.4/CMakeLists.txt#L117