WIP feat: add ot-commissioner #1285

gocarlos · 2020-04-06T09:46:47Z

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

gocarlos · 2020-04-08T12:13:26Z

depends on #1313

gocarlos · 2020-04-08T12:54:55Z

depends on #1314

gocarlos · 2020-04-23T09:05:24Z

recipes/ot-commissioner/all/conanfile.py

+        self.requires("mbedtls/2.16.3-gpl")
+        self.requires("fmt/6.1.2")
+        # TODO: port to CCI
+        self.requires("cose-c/20200225@gocarlos/testing")


waiting for #1314

The wait is over.

conan-center-bot · 2020-04-27T17:41:15Z

Failure in build 5 (8237cf620fa8e68b4b06febaf07e289871816d87):
ot-commissioner/20200404:

Error processing recipe: Linux x86_64, Release, gcc 5, libstdc++ . Options: ot-commissioner:shared-True
You are depending on 'cose-c/20200225@gocarlos/testing' but it is not in the repository

mathbunnyru · 2021-02-23T22:48:57Z

recipes/ot-commissioner/all/conanfile.py

+        # TODO: port to CCI
+        self.requires("cose-c/20200225@gocarlos/testing")


Suggested change

# TODO: port to CCI

self.requires("cose-c/20200225@gocarlos/testing")

self.requires("cose-c/cci.20200430")

Hopefully, cose-c is already in CCI, so let's try to use it.

mathbunnyru · 2021-02-23T22:50:50Z

recipes/ot-commissioner/all/conanfile.py

+        self.requires("libevent/2.1.11")
+        self.requires("mdns/20200331")
+        self.requires("nlohmann_json/3.7.3")
+        self.requires("mbedtls/2.16.3-gpl")
+        self.requires("fmt/6.1.2")


Suggested change

self.requires("libevent/2.1.11")

self.requires("mdns/20200331")

self.requires("nlohmann_json/3.7.3")

self.requires("mbedtls/2.16.3-gpl")

self.requires("fmt/6.1.2")

self.requires("libevent/2.1.12")

self.requires("mdns/20200424")

self.requires("nlohmann_json/3.9.1")

self.requires("mbedtls/2.25.0")

self.requires("fmt/7.1.3")

mathbunnyru · 2021-02-23T22:51:58Z

recipes/ot-commissioner/all/conanfile.py

+    name = "ot-commissioner"
+    description = "OpenThread Commissioner, a Thread commissioner for joining new Thread devices and managing Thread networks."
+    url = "https://github.com/conan-io/conan-center-index"
+    homepage = "https://giþthub.com/openthread/ot-commissioner"


Suggested change

homepage = "https://giþthub.com/openthread/ot-commissioner"

homepage = "https://github.com/openthread/ot-commissioner"

mathbunnyru · 2021-02-23T22:54:43Z

recipes/ot-commissioner/all/conandata.yml

+  "20200404":
+    sha256: 04a8cd1b3e79ef8f42341d50c32916806e1313bbcc76292f7f57c36ade371b18
+    url: https://github.com/gocarlos/ot-commissioner/archive/643e7e8cf803f3fd8daa09673d49badc43b4b385.zip


Why do you use your fork?

Let's use the upstream and the tagged version.
https://github.com/openthread/ot-commissioner/releases/tag/v0.0.1

mathbunnyru · 2021-02-23T22:55:07Z

recipes/ot-commissioner/all/conanfile.py

+        self.requires("mbedtls/2.16.3-gpl")
+        self.requires("fmt/6.1.2")
+        # TODO: port to CCI
+        self.requires("cose-c/20200225@gocarlos/testing")


The wait is over.

mathbunnyru · 2021-02-23T22:56:01Z

recipes/ot-commissioner/all/conanfile.py

+        # extracted_dir = self.name + "-" + self.version
+        extracted_dir = self.name + "-" + os.path.basename(self.conan_data["sources"][self.version]["url"]).split(".")[0]


Maybe it's worth using globbing?

mathbunnyru · 2021-02-23T22:56:47Z

recipes/ot-commissioner/all/test_package/test_package.cpp

+int main(){
+    std::cout << "hello world" << std::endl;
+    return 0;
+}


Suggested change

}

}

gocarlos · 2021-02-24T08:34:11Z

You are free to take over this, i changed position and therefore not using this anymore...

If someone is interested pls, pick it and improve it.... i‘m not going to be able to test this anymore and therefore leaving this open for possible interested parties

mathbunnyru · 2021-02-24T10:08:52Z

You are free to take over this, i changed position and therefore not using this anymore...

If someone is interested pls, pick it and improve it.... i‘m not going to be able to test this anymore and therefore leaving this open for possible interested parties

Thanks. I will take a look. If it's easy to get done, I will finish the work you've done.

conan-center-bot · 2021-03-07T19:06:33Z

Failure in build 6 (8237cf620fa8e68b4b06febaf07e289871816d87):

ot-commissioner/20200404@:
Error running command conan export "recipes/ot-commissioner/all/conanfile.py" ot-commissioner/20200404@:

[HOOK - conan-center.py] pre_export(): [DEPRECATED GLOBAL CPPSTD (KB-H001)] OK
[HOOK - conan-center.py] pre_export(): [REFERENCE LOWERCASE (KB-H002)] OK
[HOOK - conan-center.py] pre_export(): [RECIPE METADATA (KB-H003)] OK
[HOOK - conan-center.py] pre_export(): [HEADER_ONLY, NO COPY SOURCE (KB-H005)] OK
[HOOK - conan-center.py] pre_export(): [FPIC OPTION (KB-H006)] OK
[HOOK - conan-center.py] pre_export(): [VERSION RANGES (KB-H008)] OK
[HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] Total recipe size: 3.8779296875 KB
[HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] OK
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: ['CMakeLists.txt', 'patches/*']
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE FOLDER (KB-H024)] OK
[HOOK - conan-center.py] pre_export(): [META LINES (KB-H025)] OK
[HOOK - conan-center.py] pre_export(): [CONAN CENTER INDEX URL (KB-H027)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE MINIMUM VERSION (KB-H028)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] OK
[HOOK - conan-center.py] pre_export(): [SYSTEM REQUIREMENTS (KB-H032)] OK
[HOOK - conan-center.py] pre_export(): [CONANDATA.YML FORMAT (KB-H030)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO IMPORTS() (KB-H034)] OK
[HOOK - conan-center.py] pre_export(): [NO AUTHOR (KB-H037)] OK
[HOOK - conan-center.py] pre_export(): [NO TARGET NAME (KB-H040)] OK
[HOOK - conan-center.py] pre_export(): [NO REQUIRES.ADD() (KB-H044)] OK
[HOOK - conan-center.py] pre_export(): [DELETE OPTIONS (KB-H045)] OK
[HOOK - conan-center.py] pre_export(): bad characters: \xfe (LATIN SMALL LETTER THORN)
[HOOK - conan-center.py] pre_export():     homepage = "https://giþthub.com/openthread/ot-commissioner"
[HOOK - conan-center.py] pre_export():                           ^                                   
[HOOK - conan-center.py] pre_export(): [CMAKE WINDOWS EXPORT ALL SYMBOLS (KB-H049)] OK
[HOOK - conan-center.py] pre_export(): [DEFAULT OPTIONS AS DICTIONARY (KB-H051)] OK
[HOOK - conan-center.py] pre_export(): [CONFIG.YML HAS NEW VERSION (KB-H052)] OK
[HOOK - conan-center.py] pre_export(): [PRIVATE IMPORTS (KB-H053)] OK
[HOOK - conan-center.py] pre_export(): [SINGLE REQUIRES (KB-H055)] OK
[HOOK - conan-center.py] pre_export(): ERROR: [NO FINAL ENDLINE (KB-H041)] File '/home/conan/w/cci_PR-1285/recipes/ot-commissioner/all/test_package/test_package.cpp' does not end with an endline (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H041) 
[HOOK - conan-center.py] pre_export(): ERROR: [NO ASCII CHARACTERS (KB-H047)] The file 'conanfile.py' contains a non-ascii character at line (11). Only ASCII characters are allowed, please remove it. (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H047) 
[HOOK - conan-center.py] pre_export(): ERROR: [CMAKE VERBOSE MAKEFILE (KB-H046)] The CMake definition 'set(CMAKE_VERBOSE_MAKEFILE ON)' is not allowed. Remove it from recipes/ot-commissioner/all/test_package/CMakeLists.txt. (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H046) 
[HOOK - conan-center.py] pre_export(): ERROR: [CMAKE VERSION REQUIRED (KB-H048)] The test_package/CMakeLists.txt requires CMake 3.1 at least. Update to 'cmake_minimum_required(VERSION 3.1)'. (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H048) 
ERROR: [HOOK - conan-center.py] pre_export(): Some checks failed running the hook, check the output

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

stale · 2021-04-14T19:40:58Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2021-05-15T09:16:14Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

feat: add initial thread commissioner

e12bbef

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Apr 6, 2020

chore: update to fork

7c7c46e

This comment has been minimized.

Sign in to view

gocarlos changed the title ~~feat: add initial thread commissioner~~ feat: add ot-commissioner Apr 8, 2020

This comment has been minimized.

Sign in to view

chore: use cn-cbor from cci

8237cf6

gocarlos commented Apr 23, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

gocarlos changed the title ~~feat: add ot-commissioner~~ WIP feat: add ot-commissioner Apr 27, 2020

danimtb added the blocked Affected by an external issue and waiting until it is solved label May 4, 2020

mathbunnyru suggested changes Feb 23, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

danimtb removed the blocked Affected by an external issue and waiting until it is solved label Mar 15, 2021

stale bot added the stale label Apr 14, 2021

stale bot closed this May 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP feat: add ot-commissioner #1285

WIP feat: add ot-commissioner #1285

gocarlos commented Apr 6, 2020 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

gocarlos commented Apr 8, 2020

gocarlos commented Apr 8, 2020

This comment has been minimized.

gocarlos Apr 23, 2020

mathbunnyru Feb 23, 2021

This comment has been minimized.

conan-center-bot commented Apr 27, 2020

mathbunnyru Feb 23, 2021

mathbunnyru Feb 23, 2021

mathbunnyru Feb 23, 2021

mathbunnyru Feb 23, 2021

mathbunnyru Feb 23, 2021

mathbunnyru Feb 23, 2021

mathbunnyru Feb 23, 2021

gocarlos commented Feb 24, 2021

mathbunnyru commented Feb 24, 2021

conan-center-bot commented Mar 7, 2021

This comment has been minimized.

stale bot commented Apr 14, 2021

stale bot commented May 15, 2021

		# TODO: port to CCI
		self.requires("cose-c/20200225@gocarlos/testing")

	# TODO: port to CCI
	self.requires("cose-c/20200225@gocarlos/testing")
	self.requires("cose-c/cci.20200430")

	homepage = "https://giþthub.com/openthread/ot-commissioner"
	homepage = "https://github.com/openthread/ot-commissioner"

		# extracted_dir = self.name + "-" + self.version
		extracted_dir = self.name + "-" + os.path.basename(self.conan_data["sources"][self.version]["url"]).split(".")[0]

WIP feat: add ot-commissioner #1285

WIP feat: add ot-commissioner #1285

Conversation

gocarlos commented Apr 6, 2020 • edited Loading

This comment has been minimized.

This comment has been minimized.

gocarlos commented Apr 8, 2020

gocarlos commented Apr 8, 2020

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

conan-center-bot commented Apr 27, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gocarlos commented Feb 24, 2021

mathbunnyru commented Feb 24, 2021

conan-center-bot commented Mar 7, 2021

This comment has been minimized.

stale bot commented Apr 14, 2021

stale bot commented May 15, 2021

gocarlos commented Apr 6, 2020 •

edited

Loading