Fix SSF implementation #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caroteu
commented
Oct 15, 2024
caroteu
commented
Oct 15, 2024
|
Hi @caroteu, Thanks for the PR. I checked it out, and I do see the additional parameters now. Good job! I'll make a few checks and merge this to the original SSF PR. |
|
Okay, seems like the tests are breaking because of an issue in the latest release at It's hopefully taken care of as a post-fix in source for now (huggingface/pytorch-image-models@60f517c). Ross mentioned in an issue that he would make a release soon. I'll merge this to the running SSF PR anyways and wait until the cc: @constantinpape |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@anwai98 I made some changes in the ssf method. The number of trainable parameters for the method is ~4.27M.