Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass only the field ID to CRM_Core_BAO_CustomField::displayValue #1010

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agileware-fj
Copy link

@agileware-fj agileware-fj commented Mar 26, 2024

Overview

When building the view of custom data for cases, CiviCase was crashing with no error message. Traced this down to a problem loading custom values.
Appears to be a problem since 5.67

Before

Array of fieldInfo is passed in

  1. Have custom fields set up for case types.
  2. Go to Cases / Manage Cases.
  3. Click on a case tile to load the information, for one of the cases with custom fields.
  4. Error 500 loading case details, user is left with the placeholder images only

After

Only fieldId is passed in

On step 4, case data is fully loaded.

Comments

As noted, this is a new issue since CiviCRM 5.67; However in earlier versions including 5.51.1, the displayValue function converts passed arrays to an id as the first step anyway, so this should not introduce a compatibility problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant