Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

Crm 5.37.1 #194

Open
wants to merge 51 commits into
base: master
Choose a base branch
from
Open

Crm 5.37.1 #194

wants to merge 51 commits into from

Commits on Jun 10, 2021

  1. Remove protected _id variable from Form classes

    The visibility of this variable is public in the parent class. The overwitten visibility caused the following errors:
    PHP Fatal error:  Access level to CRM_Admin_Form_Resource:: must be public (as in class CRM_Admin_Form)
    akosgarai committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    bdfdb05 View commit details
    Browse the repository at this point in the history
  2. Add fresh underscore-umd package to the codebase

    It bumps the underscore version from 1.5.0 to 1.13.1
    akosgarai committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    95d6ff7 View commit details
    Browse the repository at this point in the history
  3. Add backbone, marionette, mobelbinder js libs to the codebase

    The backbone stack is deprecated in the civicrm. In the 5.37.1 version the libs seems to be missing (404 in browser console), so that the
    Booking frontend application is broken.
    Versions:
    - Backbone: 1.4.0 has been added (developer version). I don't know which version was used in the civi.
    - Marionette: 4.1.2 has been added (latest version). I think an older (<3) version was used in the civi.
    - Modelbinder: 1.1.1 has been added (latest version). I don't know which version was used in the civi.
    akosgarai committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    49f8eb4 View commit details
    Browse the repository at this point in the history
  4. Add json2.js to packages

    It is included from the civi backbone packages directory, so that is could be missing also.
    akosgarai committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    73030ff View commit details
    Browse the repository at this point in the history
  5. Replace the old underscore version to the new one.

    Also use the LONG_NAME variable instead of the hardcoded module name
    akosgarai committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    3f5ae63 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e4d4c51 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    19ff9c1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    15e5b54 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7893f65 View commit details
    Browse the repository at this point in the history
  10. Add crm.backbone.js to codebase and fix undefined issue

    In the browser console the following error appeared:
    Uncaught TypeError: Cannot read property 'Model' of undefined
    Solution: If the Backbone is undefined, fallback to the window.Backbone.
    akosgarai committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    2a444ad View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d9a49d8 View commit details
    Browse the repository at this point in the history
  12. Eliminate some undefined issue in add-sub-resource app

    The Backbone.Marionette is undefined in the current lib. But Marionette is defined, so it could be used instead.
    akosgarai committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    40475ac View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    d04a730 View commit details
    Browse the repository at this point in the history
  14. Move utils module code to add-sub-resource app

    As the Marionette.Module is deprecated and has been removed from the codebase, the utils.js triggered js error.
    The utils.js function has been removed and the add-sub-resource app has been extended with the removed logic.
    akosgarai committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    9c7dbab View commit details
    Browse the repository at this point in the history
  15. Fix the first creen of the new booking flow

    Console errors are not visible on the screen.
    Changes:
    - entites.js module elimination. The content has been added to the app.js.
    - addInitializer has been removed, the onStart function has to be used instead
    - move ResourceTableView from views to app as the modules are not supported
    akosgarai committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    e3b8beb View commit details
    Browse the repository at this point in the history
  16. Don't load entities.js

    akosgarai committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    bb8d366 View commit details
    Browse the repository at this point in the history
  17. Remove the common.views module

    modules are deprecated and has been removed from the codebase
    akosgarai committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    28fb44e View commit details
    Browse the repository at this point in the history
  18. Eliminate some undefined issue.

    Use CRM.$ instead of $, and CRM._ instead of _
    akosgarai committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    7871c35 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    e8fc4e9 View commit details
    Browse the repository at this point in the history
  20. Move the templates to html-header region

    On the page header regions they were loaded later than the template finder function excution.
    The missing template caused empty content.
    akosgarai committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    2336911 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    382f9c9 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    79bf915 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    bd0d01d View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. Further fixes - replace a bunch of $ to CRM.$

    Also fix the form selector
    akosgarai committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    98483c3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    20bb391 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ebdf0f4 View commit details
    Browse the repository at this point in the history
  4. Move event handlers to app

    akosgarai committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    0b35085 View commit details
    Browse the repository at this point in the history
  5. Trigger modal close event

    akosgarai committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    968d773 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5915547 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0ea6083 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4fe513c View commit details
    Browse the repository at this point in the history
  9. Move entities js object to a new js file

    As the app.js is getting too long, some of the objects could be moved to separate files.
    It helps me understanding the current issues.
    akosgarai committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    8284f37 View commit details
    Browse the repository at this point in the history
  10. Move view classes to view.js and fix event handlers

    As both modal trigger events the handler supposed to be the parent class
    akosgarai committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    2540a17 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    5d22078 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2021

  1. Make info page work without js issues

    To be honest i don't know that it works well or not. Couldn't catch the render dialog event
    akosgarai committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    27fd8c0 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Configuration menu
    Copy the full SHA
    473bf1f View commit details
    Browse the repository at this point in the history
  2. Remove crmAccordion call

    It is handled with a function in common.js that is already loaded on the form
    akosgarai committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    1fe1fb8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fac427b View commit details
    Browse the repository at this point in the history
  4. Fix jquery toggle function

    akosgarai committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    f7d6d65 View commit details
    Browse the repository at this point in the history
  5. Fix jquery function

    akosgarai committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    40b6f48 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b06f4fa View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9793b9a View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Rename OptionGroups.xml, suffix it with _install

    The current upgrader processes the xml files that has this suffix
    akosgarai committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    ae7131c View commit details
    Browse the repository at this point in the history
  2. Replace array() to [], further code updates

    Based on the solution that this fork applied: https://github.com/mjwconsult/civibooking
    akosgarai committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    123bbec View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1045461 View commit details
    Browse the repository at this point in the history
  4. Regenerate DAO with civix command

    civix generate:entity-boilerplate
    akosgarai committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    feda5a2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ff5ce6d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5a0f3fd View commit details
    Browse the repository at this point in the history
  7. Remove unnecessary files

    akosgarai committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    f086f82 View commit details
    Browse the repository at this point in the history
  8. Reorder table creations in install sql

    to resolve Unknown db error during extension install
    akosgarai committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    06cb6f6 View commit details
    Browse the repository at this point in the history
  9. Update Booking create api

    akosgarai committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    61e15e1 View commit details
    Browse the repository at this point in the history