Add trilogy GitHub workflow #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To ensure nothing breaks the trilogy adapter we want there to be a workflow that runs tests against it. So add a GitHub workflow.
Implementation
I attempted to add this here #607 but couldn't get it to work for some reason. When looking at why it works in the docker-compose file it became apparent that we needed to specify a version of mysql
5.7. The reason why may be due to one of these reasons. I didn't spend too much time digging in.I also spend some time to update the array to all be floats, because having a string in the array didn't feel quite right 😄#589. I also updated the actions checkout to the latest version.