-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: support trilogy adapter #607
Merged
cfis
merged 21 commits into
composite-primary-keys:master
from
zmariscal:feature--support-trilogy-adapter
Nov 4, 2023
Merged
Feature: support trilogy adapter #607
cfis
merged 21 commits into
composite-primary-keys:master
from
zmariscal:feature--support-trilogy-adapter
Nov 4, 2023
Commits on Sep 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c5edd75 - Browse repository at this point
Copy the full SHA c5edd75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 802587b - Browse repository at this point
Copy the full SHA 802587bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c55d81 - Browse repository at this point
Copy the full SHA 8c55d81View commit details -
Configuration menu - View commit details
-
Copy full SHA for a331a2a - Browse repository at this point
Copy the full SHA a331a2aView commit details -
ensure trilogy AR connection files are added
and specify #cpk_mysql_subquery if TrilogyAdapter is defined
Configuration menu - View commit details
-
Copy full SHA for 2109996 - Browse repository at this point
Copy the full SHA 2109996View commit details -
add private method to control #value returned
One thing we need to ensure overall is that and ActiveRecord::Result is returned as the guts of the gem is looking to work with that object. A Trilogy::Result was being returned as `value`and that doesn't respond to #empty?
Configuration menu - View commit details
-
Copy full SHA for 2b6df26 - Browse repository at this point
Copy the full SHA 2b6df26View commit details -
connect to the db if trilogy adapter used
We need to load some more files as AR isn't aware of trilogy
Configuration menu - View commit details
-
Copy full SHA for bcf5e48 - Browse repository at this point
Copy the full SHA bcf5e48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d8bbf5 - Browse repository at this point
Copy the full SHA 5d8bbf5View commit details
Commits on Sep 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dc079a2 - Browse repository at this point
Copy the full SHA dc079a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f46d5ac - Browse repository at this point
Copy the full SHA f46d5acView commit details -
Remove constant and follow pattern of if block
there's a pattern already in place as the constant may not always be defined
Configuration menu - View commit details
-
Copy full SHA for 3fc6466 - Browse repository at this point
Copy the full SHA 3fc6466View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32ef97f - Browse repository at this point
Copy the full SHA 32ef97fView commit details
Commits on Sep 26, 2023
-
when adding trilogy to various places
I accidentally added it to its own github action and we for sure need trilogy here
Configuration menu - View commit details
-
Copy full SHA for 69aced2 - Browse repository at this point
Copy the full SHA 69aced2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c95dc75 - Browse repository at this point
Copy the full SHA c95dc75View commit details -
when running tests we need to ensure AR is aware of Trilogy
so load it and make the DB connection
Configuration menu - View commit details
-
Copy full SHA for e5f311e - Browse repository at this point
Copy the full SHA e5f311eView commit details
Commits on Oct 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3de57ac - Browse repository at this point
Copy the full SHA 3de57acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 334b5a8 - Browse repository at this point
Copy the full SHA 334b5a8View commit details
Commits on Oct 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1bc20ba - Browse repository at this point
Copy the full SHA 1bc20baView commit details
Commits on Oct 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9311e0d - Browse repository at this point
Copy the full SHA 9311e0dView commit details
Commits on Nov 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 663f12a - Browse repository at this point
Copy the full SHA 663f12aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f79e913 - Browse repository at this point
Copy the full SHA f79e913View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.