Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percolator fixes: ScanNr writing and inferring style from file extension #94

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

RalfG
Copy link
Member

@RalfG RalfG commented Aug 28, 2024

Fixed

  • io.percolator: Fix and improve ScanNr inferring and writing
  • io.percolator: Infer style from file extension if not provided (enables dynamic style determination in, for instance, convert function).

@RalfG RalfG added bug Something isn't working enhancement Improvement of an existing feature labels Aug 28, 2024
@RalfG RalfG added this to the v1.0.1 milestone Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 66.10169% with 20 lines in your changes missing coverage. Please review.

Project coverage is 65.96%. Comparing base (50f9a9c) to head (711fd10).
Report is 4 commits behind head on main.

Files Patch % Lines
psm_utils/io/percolator.py 65.51% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   65.19%   65.96%   +0.77%     
==========================================
  Files          26       26              
  Lines        2508     2533      +25     
==========================================
+ Hits         1635     1671      +36     
+ Misses        873      862      -11     
Flag Coverage Δ
unittests 65.96% <66.10%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RalfG RalfG merged commit 5e42ace into main Aug 28, 2024
7 checks passed
@RalfG RalfG deleted the fix/percolator-scannr branch August 28, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant