Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TSV reading error handling #88

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

RalfG
Copy link
Member

@RalfG RalfG commented Aug 14, 2024

Fixed

  • TSV: Avoid flooding logs when reading a different file format by raising exception when three consecutive rows could not be parsed

@RalfG RalfG added the bug Something isn't working label Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.06%. Comparing base (8438dbc) to head (dd9aac0).

Files Patch % Lines
psm_utils/io/tsv.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   64.73%   65.06%   +0.33%     
==========================================
  Files          26       26              
  Lines        2501     2505       +4     
==========================================
+ Hits         1619     1630      +11     
+ Misses        882      875       -7     
Flag Coverage Δ
unittests 65.06% <85.71%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RalfG RalfG added this to the v0.10.0 milestone Aug 14, 2024
@RalfG RalfG merged commit 0d5af95 into main Aug 14, 2024
7 checks passed
@RalfG RalfG deleted the feature/tsv-raise-exception branch August 14, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant