Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProteoScape / TIMScore improvements #75

Merged
merged 3 commits into from
Mar 29, 2024
Merged

ProteoScape / TIMScore improvements #75

merged 3 commits into from
Mar 29, 2024

Conversation

RalfG
Copy link
Member

@RalfG RalfG commented Mar 29, 2024

Added

  • io.proteoscape: Allow ProteoScapeReader instantiation from Pandas DataFrame and access PSM by index.

Changed

  • io.proteoscape: Rename module from TIMScore to ProteoScape.
  • io.proteoscape: Use correct search engine score (x_corr_score instead of tims_score)

Fixed

  • Remove accidental print statement.

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (10086b1) to head (f649b6c).

Files Patch % Lines
psm_utils/io/proteoscape.py 0.00% 43 Missing ⚠️
psm_utils/io/_utils.py 0.00% 5 Missing ⚠️
psm_utils/io/__init__.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #75   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         25      25           
  Lines       2405    2415   +10     
=====================================
- Misses      2405    2415   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RalfG RalfG merged commit 21521c6 into main Mar 29, 2024
5 checks passed
@RalfG RalfG deleted the add-prolucid-support branch March 29, 2024 10:03
@RalfG RalfG added bug Something isn't working enhancement Improvement of an existing feature labels Mar 29, 2024
@RalfG RalfG added this to the 0.8.1 milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants