Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests #31

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Update tests #31

merged 3 commits into from
Apr 11, 2024

Conversation

Braqzen
Copy link
Collaborator

@Braqzen Braqzen commented Apr 11, 2024 •
edited
Loading

Changes

  • Minor contract fix for withdrawing to allow current tests to pass (withdrawing likely needs adjustment anyway)
  • SDK update to prevent running out of gas in tests.
    • This may need to be made configurable in the future rather than hardcoded into the API
  • Updated multiple tests to pass that were broken or ignored.
    • 4 tests are still commented out and batch_fulfill needs to be done at the end

Note: This should be reviewed and then merged after #30

@Braqzen Braqzen added the enhancement New feature or request label Apr 11, 2024
@Braqzen Braqzen marked this pull request as ready for review April 11, 2024 17:14
@Braqzen Braqzen requested a review from chlenc April 11, 2024 17:15
@Braqzen Braqzen merged commit ffa7972 into development Apr 11, 2024
4 checks passed
@Braqzen Braqzen deleted the update-tests branch April 11, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlenc chlenc chlenc approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Braqzen @chlenc