Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start docs on compilation process #382

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented Nov 20, 2024

@willtebbutt following our discussion on IR, you'll find my notes here. I'm thinking some of them can go into the docs (as a substitute for proper docs of Core.Compiler) and some can go in #337.

@gdalle gdalle marked this pull request as draft November 20, 2024 11:12
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes


🚨 Try these New Features:

@willtebbutt
Copy link
Member

Thanks for these @gdalle -- I'd quite to get them merged into the docs (maybe with some tweaks). It looks like the docs are failing to build at the minute because it thinks that some of your links are invalid.

@gdalle
Copy link
Collaborator Author

gdalle commented Nov 20, 2024

Oh right, I think that's because I added these links starting from docs/src but in reality the docs are built from the docs working directory, so there is probably one .. too many. Do you want to remove it and make the necessary rephrasing before merging? My notes are not really mergeable in the current state anyway, so I thought you would want to reformulate and clean them up a bit, possibly correcting inaccuracies.

@willtebbutt
Copy link
Member

Sounds good -- are you happy for me to push to this branch directly? (I assume that I can do that...)

@gdalle
Copy link
Collaborator Author

gdalle commented Nov 20, 2024

Yeah take it away. But maybe save the remarks about forward mode specifically to the relevant issue before erasing them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants