Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to python 3.11 #267

Merged
merged 2 commits into from
May 7, 2024

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented May 5, 2024

This should allow the pip version error to not appear, while not having the issue introduced in the last PR. Will know for sure once ci has run on this PR.

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.45%. Comparing base (f93e7b6) to head (5d91d19).
Report is 20 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #267       +/-   ##
===========================================
- Coverage   87.65%   75.45%   -12.21%     
===========================================
  Files           4        8        +4     
  Lines        1742     2994     +1252     
===========================================
+ Hits         1527     2259      +732     
- Misses        215      735      +520     

see 8 files with indirect coverage changes

see 8 files with indirect coverage changes

@mcbarton
Copy link
Collaborator Author

mcbarton commented May 5, 2024

@vgvassilev I changed the python version to 3.11 like the other repos. This has some jobs failing that aren't in the other repos, but this appears to be due to differences in the ci. I will investigate but suggest merging for now.

@aaronj0
Copy link
Collaborator

aaronj0 commented May 6, 2024

@mcbarton there is a PR #268 that is fixing the recent regressions on the CI, which mostly stems from Valgrind preventing the build CppInterOp step from not progressing further, reverting the python version to 3.10 and CUDA. I would suggest that we hold on landing this PR for now

@mcbarton
Copy link
Collaborator Author

mcbarton commented May 6, 2024

@mcbarton there is a PR #268 that is fixing the recent regressions on the CI, which mostly stems from Valgrind preventing the build CppInterOp step from not progressing further, reverting the python version to 3.10 and CUDA. I would suggest that we hold on landing this PR for now

@maximusron In your PR can you change it to python 3.11 and fix the Valgrind error after the CppInterOp build? We can then change the Valgrind check in the other repos to also not unconditionally return true (See https://github.com/compiler-research/cppyy-backend/blob/c4854922de0afa96e9acd3f8f147a292d2e72776/.github/workflows/ci.yml#L586C1-L588C11 as an example). I will then close this PR.

@mcbarton
Copy link
Collaborator Author

mcbarton commented May 6, 2024

@maximusron Relating to CUDA and CppInterOp. Do you think this may be useful for the workflow in future in CppInterOp? github/roadmap#961 .

@mcbarton
Copy link
Collaborator Author

mcbarton commented May 6, 2024

@mcbarton there is a PR #268 that is fixing the recent regressions on the CI, which mostly stems from Valgrind preventing the build CppInterOp step from not progressing further, reverting the python version to 3.10 and CUDA. I would suggest that we hold on landing this PR for now

@maximusron In your PR can you change it to python 3.11 and fix the Valgrind error after the CppInterOp build? We can then change the Valgrind check in the other repos to also not unconditionally return true (See https://github.com/compiler-research/cppyy-backend/blob/c4854922de0afa96e9acd3f8f147a292d2e72776/.github/workflows/ci.yml#L586C1-L588C11 as an example). I will then close this PR.

The reason I am suggesting 3.11 instead of 3.10 is that returing to 3.10 returns an error when the workflow reruns with regards to the pip version, which we have no ability to stop appearing. The goal is to have no errors appear when the workflow runs.

@aaronj0
Copy link
Collaborator

aaronj0 commented May 6, 2024

fix the Valgrind error after the CppInterOp build?

yep this is done in the PR, will take a look at windows next. Regarding the python versions, that can be tried at the end since we have the option to revert safely.

Relating to CUDA and CppInterOp. Do you think this may be useful for the workflow in future in CppInterOp? github/roadmap#961 .

If the runner has an Nvidia GPU then the rest is something we can set up in theory, installing the nvidia-drivers package and use the rpm for CUDA sdk installaion. Maybe this can be opened as an issue as a future upgrade for the CI

@mcbarton
Copy link
Collaborator Author

mcbarton commented May 7, 2024

@vgvassilev After the changes by @maximusron I can now update to a newer version of python, removing the pip version warning from runs of the ci, without it breaking the ci. I believe this should be merged along with
compiler-research/CPyCppyy#52
compiler-research/cppyy-backend#101
compiler-research/cppyy#80

@aaronj0
Copy link
Collaborator

aaronj0 commented May 7, 2024

rerunning jobs on this PR to see if python 3.11 works over the recent PR's merged

@mcbarton
Copy link
Collaborator Author

mcbarton commented May 7, 2024

@maximusron are you able to merge this PR, alongside the other PRs mentioned above, now your rerun is complete?

@aaronj0
Copy link
Collaborator

aaronj0 commented May 7, 2024

@mcbarton @vgvassilev the run was successfull, this PR is good to go

@aaronj0 aaronj0 merged commit 542fc55 into compiler-research:main May 7, 2024
30 of 35 checks passed
@mcbarton mcbarton deleted the change-to-python-3.11 branch May 22, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants