Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robot library #406

Merged
merged 31 commits into from
Apr 12, 2024
Merged

Robot library #406

merged 31 commits into from
Apr 12, 2024

Conversation

yck011522
Copy link
Contributor

This PR adds some default robots that can be loaded from a RobotLibrary class

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_fab.robots.CollisionMesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@yck011522 yck011522 mentioned this pull request Feb 19, 2024
10 tasks
@yck011522 yck011522 marked this pull request as ready for review February 19, 2024 08:25
@yck011522 yck011522 changed the base branch from compas-2.x-compat to main February 19, 2024 10:23
@yck011522 yck011522 self-assigned this Feb 20, 2024
@yck011522 yck011522 mentioned this pull request Feb 20, 2024
10 tasks
@yck011522
Copy link
Contributor Author

@gonzalocasas See if you have time to review this one. I think it is ready. And after this one, can go with #407.

Copy link
Member

@gonzalocasas gonzalocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good! I added a bunch of feedback. In my opinion, the rotation issue needs to be resolved by removing the rotation.

docs/examples/02_description_models/03_robot_instances.rst Outdated Show resolved Hide resolved
docs/examples/02_description_models/03_robot_instances.rst Outdated Show resolved Hide resolved
docs/examples/02_description_models/03_robot_instances.rst Outdated Show resolved Hide resolved
docs/examples/02_description_models/03_robot_instances.rst Outdated Show resolved Hide resolved
src/compas_fab/robots/robot_library.py Outdated Show resolved Hide resolved
src/compas_fab/robots/robot_library.py Outdated Show resolved Hide resolved
src/compas_fab/robots/robot_library.py Outdated Show resolved Hide resolved
src/compas_fab/robots/robot_library.py Show resolved Hide resolved
Copy link
Member

@gonzalocasas gonzalocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@yck011522 yck011522 merged commit d088aee into main Apr 12, 2024
15 checks passed
@yck011522 yck011522 deleted the robot_library branch April 12, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants