Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compas 2 private Data API #400

Merged
merged 25 commits into from
Feb 6, 2024

Conversation

yck011522
Copy link
Contributor

@yck011522 yck011522 commented Jan 30, 2024

Supporting the new compas 2 private Data API.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_fab.robots.CollisionMesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@yck011522
Copy link
Contributor Author

Note to myself that this branch is currently running against compas 2.0.0b4 with an unmerged fix:
https://github.com/compas-dev/compas/tree/bugfix/sphere_intersection

compas_robot is still under active fix

@yck011522
Copy link
Contributor Author

At the moment, the two failing CI are:

build / windows-ironpython

Need to change workflow to install compas_robots

integration / ubuntu-py38-integration

doctest is failing

=========================== short test summary info ============================
SKIPPED [2] ../../../../../opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/_pytest/doctest.py:460: all tests skipped by +SKIP option
FAILED docs/examples/03_backends_ros/03_forward_and_inverse_kinematics.rst::line:36,column:1 - roslibpy.core.RosTimeoutError: Failed to connect to ROS
FAILED docs/examples/03_backends_ros/03_forward_and_inverse_kinematics.rst::line:49,column:1 - roslibpy.core.RosTimeoutError: Failed to connect to ROS
FAILED docs/examples/03_backends_ros/03_forward_and_inverse_kinematics.rst::line:54,column:1 - roslibpy.core.RosTimeoutError: Failed to connect to ROS
FAILED docs/examples/03_backends_ros/04_plan_motion.rst::line:23,column:1 - roslibpy.core.RosTimeoutError: Failed to connect to ROS
FAILED docs/examples/03_backends_ros/04_plan_motion.rst::line:32,column:1 - roslibpy.core.RosTimeoutError: Failed to connect to ROS
FAILED docs/examples/03_backends_ros/05_collision_objects.rst::line:33,column:1 - roslibpy.core.RosTimeoutError: Failed to connect to ROS
FAILED docs/examples/03_backends_ros/05_collision_objects.rst::line:50,column:1 - roslibpy.core.RosTimeoutError: Failed to connect to ROS
FAILED docs/examples/03_backends_ros/05_collision_objects.rst::line:70,column:1 - roslibpy.core.RosTimeoutError: Failed to connect to ROS
FAILED docs/examples/05_backends_pybullet/01_pybullet_examples.rst::line:55,column:1 - AttributeError: 'Color' object has no attribute 'get_urdf_element'

Mostly due to geometry __str__ no longer printing in the same way.
Except the case where the error caused by compas_robot : AttributeError: 'Color' object has no attribute 'get_urdf_element'

.github/workflows/build.yml Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
src/compas_fab/robots/robot.py Outdated Show resolved Hide resolved
src/compas_fab/robots/semantics.py Outdated Show resolved Hide resolved
Copy link
Member

@gonzalocasas gonzalocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 lgtm!

@gonzalocasas gonzalocasas merged commit 9a22f01 into compas-2.x-compat Feb 6, 2024
2 of 6 checks passed
@gonzalocasas gonzalocasas deleted the support_private_data branch February 6, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants