-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support compas 2 private Data API #400
Conversation
One test still failing
Note to myself that this branch is currently running against compas 2.0.0b4 with an unmerged fix: compas_robot is still under active fix |
This reverts commit 905c496.
At the moment, the two failing CI are: build / windows-ironpythonNeed to change workflow to install compas_robots integration / ubuntu-py38-integrationdoctest is failing
Mostly due to geometry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 lgtm!
Supporting the new compas 2 private Data API.
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas_fab.robots.CollisionMesh
.