Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation to knnDE function #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added documentation to knnDE function #26

wants to merge 3 commits into from

Conversation

benholmgren
Copy link
Contributor

Briefly explained parameters and return value with roxygen style comments, then added documentation to walk through code

@benholmgren
Added documentation to knnDE function
4d329c2 
Briefly explained parameters and return value with roxygen style comments, then added documentation to walk through code
dlm
dlm reviewed Feb 23, 2019
View reviewed changes
Copy link
Contributor

@dlm dlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous. I'll let you take another stab at cleaning up and we can discuss on Mon. But overall, looks good!

@benholmgren
Revised comments for knnDE
ff3a754 
Streamlined comments
@benholmgren
Added title to knnDE roxygen
03c10c5 
roxygen needs a title to make documentation reliably
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlm dlm dlm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benholmgren @dlm