Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FOR DISCUSSION: Using coroutines for login #5695

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

FOR DISCUSSION: Using coroutines for login #5695

wants to merge 6 commits into from

Commits on Apr 13, 2024

  1. Stating the cleanup by clearing IDE warnings and moving public constants

    @psh
    psh committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    e9c1022 View commit details
    Browse the repository at this point in the history

  2. Convert NetworkingModule to kotlin

    @psh
    psh committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    cc4c418 View commit details
    Browse the repository at this point in the history

  3. Mark the exiting service factory (rx based) as deprecated

    @psh
    psh committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    3ff6135 View commit details
    Browse the repository at this point in the history

  4. Move networking dagger modules around to support the Coroutines migra… 

    …tion with Login as the starting point
    @psh
    psh committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    ddb0caf View commit details
    Browse the repository at this point in the history

  5. Add a viewmodel to manage coroutines scopes/lifecycle for us

    @psh
    psh committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    32eaaf1 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Convert the LoginInterface to use suspend functions, and integrate in… 

    …to the app
    @psh
    psh committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    881dbcf View commit details
    Browse the repository at this point in the history