Include author info in the Thanks toast #5211
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
The toast shown when thanking an author during review did not include the author's name in it. It is important to show the same since the thank is explicitly sent to the author.
What changes did you make and why?
Included the author info in the thank related toasts.
Tests performed (required)
OnePlus Nord running Android 12
Screenshots (for UI changes only)
Successful thank toast
Draft status reason
I'm not really sure what to do about the corresponding strings in other languages. I suppose the app would be handling them incorrectly since they only take one parameter. Do let me know your thoughts about the same.
Update: I just checked and it seems to be showing the author name in place of the media file name. So, the meaning of the text seems to change unexpectedly. We could shuffle the params around to fix this like
Sending thanks for $filename to $authorname
but the sentence does not seem to read well to me.I could think of another alternative too. Anyways, let me hear other's thoughts before that.
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.