Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NCC Audit Fixes #1

Draft
wants to merge 10 commits into
base: ncc-audit
Choose a base branch
from
Draft

NCC Audit Fixes #1

wants to merge 10 commits into from

Conversation

k4m4
Copy link
Member

@k4m4 k4m4 commented Dec 27, 2024 •
edited
Loading

Findings:

  • NCC-E010021-YXX: pending discussion
  • NCC-E010021-K3F: pending discussion
  • NCC-E010021-HQN: cc2d13e
  • NCC-E010021-TUH: 8028f07
  • NCC-E010021-2HB: bfac90d
  • ab2f505
  • NCC-E010021-6PR: bc537e8
  • NCC-E010021-C44: TODO

Implementation review notes:

  • Unaddressed ToDos should be tracked: TODO
  • Multiplication with -1 could be avoided: ab2f505
  • Unnecessary save to storage: 5566061
  • Stale Link in Serialize Code: 41d970c
  • Code Comment Should be Expanded: 04194ba
  • Weight Scaling Behavior should be Documented: b792c72

k4m4 added 10 commits December 27, 2024 13:28
@k4m4
fix(xrpl-multisig-prover): use checked arithmetic for Uint256::{add,s…
cc2d13e 
…ub} dust accounting
@k4m4
fix(xrpl-multisig-prover): use mul_ceil in quorum calculation
8028f07
@k4m4
fix(xrpl-{multisig-prover,types}): use informative errors in XRPLPath…
bfac90d 
…Set serialization
@k4m4
chore(xrpl-multisig-prover): remove redundant commented function
86f7f4d
@k4m4
fix(xrpl-ampd): gracefully return false if memo type is not valid hex
bc537e8
@k4m4
chore(xrpl-types): remove redundant negation in XRPLTokenAmount::from…
ab2f505 
…_str
@k4m4
chore(xrpl-multisig-prover): avoid unnecessary storage write in save_…
5566061 
…next_verifier_set
@k4m4
chore(xrpl-multisig-prover): fix broken link in XRPL encoding comment
41d970c
@k4m4
chore(xrpl-voting-verifier): add comment to clarify that source gatew…
04194ba 
…ay is controlled by multisig prover
@k4m4
chore(xrpl-multisig-prover): add comment to clarify why convert_or_sc…
b792c72 
…ale_weights is needed
@k4m4 k4m4 self-assigned this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@k4m4 k4m4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@k4m4