Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spicy version of the Map UI optimisaiton #106

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

Arbyhisenaj
Copy link
Member

Description

There's too many, but the main ones:

  • Managing data now exists in settings (separate of managing and exploring contexts for users)
  • Using a single sidebar with known as the navigator which uses tabs for the different data you can explore
  • Members are listed in a table that is searchable
  • Constituencies have a list column and selected content column
  • Constituencies are searchable

issues remaining:

  • I think the member list is only showing one source? need to check that it shows all the sources
  • Need to adjust the 'vanishing point' for the Map as when the sidebar expands, the map doesn't adjust what's important.
  • I'm not seeing the actual constituency data for some reason? I see it in the code but not in the browser. Not getting error messages in the console either.
  • would be good show all constituencies instead of the ones just your members are in?
  • Pinned feature
  • Finessing the design to match figma

Motivation and Context

Optimising based on initial feedback from the onboarding process

How Can It Be Tested?

How Will This Be Deployed?

Screenshots (if appropriate):

Standardized Screenshot (3)
Standardized Screenshot (2)
Standardized Screenshot (4)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I've checked the spec (e.g. Figma file) and documented any divergences.
  • My code follows the code style of this project.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I've updated the documentation accordingly.
  • Replace unused checkboxes with bullet points

@janbaykara
Copy link
Member

Screenshot 2024-06-18 at 10 12 03

Feel like this should be styled as rows divided by a border, rather than a series of cards.

@Arbyhisenaj
Copy link
Member Author

Screenshot 2024-06-18 at 10 12 03 Feel like this should be styled as rows divided by a border, rather than a series of cards.

image
Like this?

@commonknowledge-bot commonknowledge-bot deployed to design/facelift-spicy-push - meep-intelligence-hub-worker PR #106 June 20, 2024 10:26 — with Render Active
@commonknowledge-bot commonknowledge-bot deployed to design/facelift-spicy-push - meep-intelligence-hub-worker PR #106 June 20, 2024 10:31 — with Render Active
@commonknowledge-bot commonknowledge-bot temporarily deployed to design/facelift-spicy-push - meep-intelligence-hub-frontend PR #106 June 20, 2024 10:31 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to design/facelift-spicy-push - meep-intelligence-hub-worker PR #106 June 21, 2024 16:12 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to design/facelift-spicy-push - meep-intelligence-hub-frontend PR #106 June 21, 2024 16:12 — with Render Destroyed
@commonknowledge-bot commonknowledge-bot temporarily deployed to design/facelift-spicy-push - meep-intelligence-hub-backend PR #106 June 21, 2024 16:12 — with Render Destroyed
@janbaykara
Copy link
Member

Somewhat inspired by the UI prototyping done here by @Arbyhisenaj and based on new requirements and roadmap plans, @GemCopeland and @ev-sc are working on an new iteration of the private mapping UI. So I propose we close this PR. Leave it to @joaquimds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants