Run Stripe subscription syncing middleware only on specific pages #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moggach
force-pushed
the
adjust-slow-middleware-syncing-subs
branch
from
d2d6f0d
to
240a3c4
Compare
|
LGTM. Just would be good to fix that CI error. |
janbaykara
approved these changes
Sep 4, 2024
okay cool. The linter has picked up some Typescript errors that are not to do with this PR so I'll close this and make a separate PR for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the update_stripe_customer_subscription function to run only on specific page paths that concern changes to subscriptions
Motivation and Context
Existing code running this function on every page load is causing page load times of 6-7 seconds when user is logged in