Preserve blanks and uses #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemitchell
force-pushed
the
preserve-blanks-and-uses
branch
2 times, most recently
from
77ca79b
to
ed27b17
Compare
Return `{ use: "Term" }` and `{ blank: "Blank", value: "Value" }`,
rather than convert those content elements to strings. This will allow
downstream renderers to style term uses and blanks.
All non-string content objects are now passed through as objects. There's no longer need to check whether resolution created contiguous strings in a content array.
kemitchell
force-pushed
the
preserve-blanks-and-uses
branch
from
ed27b17
to
07ced1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the package to return
{use: "Term"}and{blank: "Blank", value: "Value"}when appropriate, rather than converting those content elements to strings.This will allow renderers to style term uses and blanks, filled or unfilled.
It's a SemVer breaking change.
cc: @anseljh