Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requiresBillingInfo prop to the ResourceAddress component #815

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

marcomontalbano
Copy link
Member

@marcomontalbano marcomontalbano commented Oct 25, 2024

What I did

This PR adds/edits a few things to the ResourceAddress component:

  • 💥 Breaking Change - I renamed the prop resource to address.
  • I added a new prop called requiresBillingInfo. When true, it forces billing_info as a required field.
  • I removed unnecessary re-renders.

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for commercelayer-app-elements ready!

Name Link
🔨 Latest commit 38da238
🔍 Latest deploy log https://app.netlify.com/sites/commercelayer-app-elements/deploys/671bdebec2f4320008dc4fc5
😎 Deploy Preview https://deploy-preview-815--commercelayer-app-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcomontalbano marcomontalbano merged commit 3122944 into main Oct 28, 2024
5 checks passed
@marcomontalbano marcomontalbano deleted the resource-address-new-requiresBillingInfo-prop branch October 28, 2024 08:49
@marcomontalbano marcomontalbano self-assigned this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants