Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add organization-config schema to the CodeEditor component #798

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

marcomontalbano
Copy link
Member

@marcomontalbano marcomontalbano commented Oct 11, 2024

What I did

I added an organization-config value to the jsonSchema property for the CodeEditor component.

This setting will help you in writing a proper valid JSON for the organization.config attribute.

How to test

json-schema-for-organization-config.mp4

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for commercelayer-app-elements ready!

Name Link
🔨 Latest commit b0209ac
🔍 Latest deploy log https://app.netlify.com/sites/commercelayer-app-elements/deploys/67321de7b4674b0008a69c4f
😎 Deploy Preview https://deploy-preview-798--commercelayer-app-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@pfferrari pfferrari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@marcomontalbano marcomontalbano marked this pull request as ready for review November 27, 2024 18:57
@marcomontalbano marcomontalbano merged commit 2937819 into main Nov 27, 2024
7 checks passed
@marcomontalbano marcomontalbano deleted the code-editor-organization-config branch November 27, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants