Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button with variant link now renders as a link #308

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Button with variant link now renders as a link #308

merged 1 commit into from
Aug 22, 2023

Conversation

marcomontalbano
Copy link
Member

What I did

When you create a link button:

<Button variant="link">I am a Button</Button>

now it renders as an <A> tag.

Screenshot 2023-08-21 alle 21 32 40

@marcomontalbano marcomontalbano added the bug Something isn't working label Aug 21, 2023
@marcomontalbano marcomontalbano merged commit 9607f2f into main Aug 22, 2023
1 check passed
@marcomontalbano marcomontalbano deleted the button-as-link branch August 22, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfferrari pfferrari pfferrari approved these changes

@malessani malessani Awaiting requested review from malessani

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcomontalbano @pfferrari