Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply UI refinements to SearchBar #306

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Apply UI refinements to SearchBar #306

merged 1 commit into from
Aug 21, 2023

Conversation

pfferrari
Copy link
Contributor

@pfferrari pfferrari commented Aug 21, 2023

What I did

I re-applied some fixes that we made to SearchBar and got lost due to a merge of an old accessibility branch about SearchBar. Probably the rebase made in this branch was not able to wrap up correctly old and new stuff.

Along the revamp of old fixes I cleaned up some useless classnames to simplify the component.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@pfferrari pfferrari added the bug Something isn't working label Aug 21, 2023
@pfferrari pfferrari self-assigned this Aug 21, 2023
@pfferrari pfferrari merged commit ccac3f2 into main Aug 21, 2023
1 check passed
@pfferrari pfferrari deleted the refine-searchbar branch August 21, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants