Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid useless api requests in ResourceTags #304

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

pfferrari
Copy link
Contributor

What I did

  • I removed no more used api request to gather all organization tags previously used to fill the default status of the select.
  • I added a check in the tags search InputSelect loadAsyncValues prop in order to avoid the search if hint is empty.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@pfferrari pfferrari added the bug Something isn't working label Aug 17, 2023
Copy link
Contributor

@malessani malessani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pfferrari pfferrari self-assigned this Aug 17, 2023
@pfferrari pfferrari merged commit 979ac96 into main Aug 18, 2023
1 check passed
@pfferrari pfferrari deleted the avoid-useless-api-resourcestags branch August 18, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants