Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage sticky buttons by using only TailwindCSS #288

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

pfferrari
Copy link
Contributor

@pfferrari pfferrari commented Aug 10, 2023

What I did

  • I modified previously implemented sticky button in Overlay component to remove all Javascript activation logic in favour of relying only on TailwindCSS classnames used in a correct container structure
  • I modified hook-form FiltersForm component to let the form button to become sticky via TailwindCSS classnames by reusing the same elements structure used in Overlay component
  • The two components are actually sharing the same structure in order to define a sort of pattern reusable in other similar cases
FiltersFormWithStickyButton.mov

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@pfferrari pfferrari added the enhancement New feature or request label Aug 10, 2023
Copy link
Contributor

@malessani malessani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pfferrari pfferrari merged commit 95050e7 into main Aug 11, 2023
@pfferrari pfferrari deleted the sticky-buttons-only-tw branch August 11, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants