Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CopyToClipboard empty value #287

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Update CopyToClipboard empty value #287

merged 2 commits into from
Aug 9, 2023

Conversation

pfferrari
Copy link
Contributor

What I did

I replaced CopyToClipboard's empty value to fit new design standard for empty strings to be a gray-300 dash symbol ( — ).

CopyToClipboardEmptyDash

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@pfferrari pfferrari requested review from gciotola, marcomontalbano and malessani and removed request for gciotola August 9, 2023 13:31
@pfferrari pfferrari added bug Something isn't working task enhancement New feature or request and removed bug Something isn't working task labels Aug 9, 2023
marcomontalbano
marcomontalbano previously approved these changes Aug 9, 2023
View reviewed changes
malessani
malessani approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@malessani malessani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pfferrari pfferrari merged commit 66d950d into main Aug 9, 2023
1 check passed
@pfferrari pfferrari deleted the replace-copytoclipboard-empty-value branch August 9, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malessani malessani malessani approved these changes

@marcomontalbano marcomontalbano marcomontalbano left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pfferrari @marcomontalbano @malessani