Merge pull request #469 from commercekitchen/remove_student_ids_for_p…

…arents Don't show student ID field for parents
commercekitchen · Jul 20, 2020 · be2c79a · be2c79a
2 parents aefa5b9 + 509b3a0
commit be2c79a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/app/assets/javascripts/registrations/schools_form.js b/app/assets/javascripts/registrations/schools_form.js
@@ -22,12 +22,10 @@ var schoolsForm = (function () {
 
   function showStudentFields() {
     $("#student-only").show();
-    $("#user_student_id").attr("placeholder", "Student ID # *");
   }
 
   function hideStudentFields() {
     $("#student-only").hide();
-    $("#user_student_id").attr("placeholder", "Students' ID #s");
   }
 
   function makeStudentIdRequired() {

diff --git a/app/views/devise/registrations/_schools_form.html.erb b/app/views/devise/registrations/_schools_form.html.erb
@@ -26,9 +26,9 @@
 
   </fieldset>
 
-</div>
+  <div class="form-row">
+    <%= f.label :student_id, t('login_signup.student_id'), class: "signup-label" %>
+    <%= f.text_field :student_id, placeholder: "Student ID # *", required: true %>
+  </div>
 
-<div class="form-row">
-  <%= f.label :student_id, t('login_signup.student_id'), class: "signup-label" %>
-  <%= f.text_field :student_id, placeholder: "Students' ID #s" %>
 </div>