Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dutch states #502

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Dutch states #502

wants to merge 6 commits into from

Conversation

PanderMusubi
Copy link
Contributor

No description provided.

@PanderMusubi
Copy link
Contributor Author

Working on adding proper tests.

@PanderMusubi
Copy link
Contributor Author

PanderMusubi commented Dec 31, 2024 •
edited
Loading

@commenthol please advise: the remaining errors do not appear when I run the test locally. Actually, I had to change these lines around to make the local test work.

Perhaps it is good to investigate what causes this difference in ordering? Perhaps an explicit wort is needed in the code to have the software be deterministic and not depend on installed version. I am using Pop!_OS 22.04 LTS with npm 8.5.1~ds-1 and nodejs 12.22.9~dfsg-1ubuntu3.6.

@PanderMusubi
Copy link
Contributor Author

@commenthol I can't get the tests to succeed, can you help me with this?

@PanderMusubi
Copy link
Contributor Author

@commenthol all errors have been fixed.

@commenthol
Copy link
Owner

@PanderMusubi Can you please rebase your changes from the recent master branch and resolve the potential conflicts then. I'd prefer this instead of the force push. Thanks for your help.

@PanderMusubi
Copy link
Contributor Author

I hope this fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PanderMusubi @commenthol