-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved Dutch translations #473
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except for O.L.V. Hemelvaart
and O.L.H. Hemelvaart
, have a look at my comments and let me know what you think!
yep, fixed it in next commit the way you proposed it, now I see Hemelvaartsdag in the NL.,yml file. |
@ehoogeveen-medweb what do you think about adding these local days to observe:
as they have a major impact on local businesses and local infrastructure How about these national days that have impact on a national level:
The following national one, but if they are not to be included, also not include Koninkrijksdag:
And these international days that have impact on infrastructure:
|
Can you please run the (re-) generation of the test fixtures as stated in CONTRIUTING.md? Thanks.
|
thanks, done |
Being local days, it might make sense to add them in states or regions (see e.g. the German data).
Ketikoti is already in there, right? I don't think there's a precedent for including DST changes, but I could be wrong. They don't seem like they fit any definition of holidays at least.
I think it's fine to include these as
Same with these, though I don't know where to draw the line with regard to international days (since it seems like people keep making up more). I guess the question is whether people take the day off for them - though for something like Halloween, it seems more likely that people would take the next day off. |
For almost fifteen years, I have been maintaining https://github.com/PanderMusubi/dutch-holidays (which was also used by Thunderbird) and would like to contribute to this project and slowly move the relevant data to here.