feat: Updated for Bolivian holidays #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jhordyess
commented
Oct 13, 2023
jhordyess
commented
- Included substitute holidays
- Added the most commonly observed days
- Removed Easter Sunday, Ascension Day, and Agrarian Reform Day
- Updated with commonly used names
- Added state-specific holidays
- Included substitute holidays - Added the most commonly observed days - Removed Easter Sunday, Ascension Day, and Agrarian Reform Day - Updated with commonly used names - Added state-specific holidays
commenthol
reviewed
Oct 15, 2023
data/countries/BO.yaml
Outdated
| @@ -1,5 +1,7 @@ | |||
| holidays: | |||
| # @attrib https://en.wikipedia.org/wiki/Public_holidays_in_Bolivia | |||
| # @attrib https://www.timeanddate.com/holidays/bolivia/ | |||
There was a problem hiding this comment.
Do not use data from this service as its data needs to be licensed.
commenthol
reviewed
Oct 15, 2023
data/countries/BO.yaml
Outdated
| @@ -1,5 +1,7 @@ | |||
| holidays: | |||
| # @attrib https://en.wikipedia.org/wiki/Public_holidays_in_Bolivia | |||
| # @attrib https://www.timeanddate.com/holidays/bolivia/ | |||
| # @attrib http://gacetaoficialdebolivia.gob.bo/normas/buscar/5019 | |||
There was a problem hiding this comment.
Use @source here as we don't need to attribute the link in the source.
commenthol
reviewed
Oct 15, 2023
data/countries/BO.yaml
Outdated
| # @attrib https://en.wikipedia.org/wiki/Public_holidays_in_Bolivia | ||
| # @attrib https://www.timeanddate.com/holidays/bolivia/ | ||
| # @attrib http://gacetaoficialdebolivia.gob.bo/normas/buscar/5019 | ||
| # @attrib https://www.embajadadebolivia.es/informacion-general/ |
commenthol
reviewed
Oct 15, 2023
| @@ -1,5 +1,7 @@ | |||
| holidays: | |||
| # @attrib https://en.wikipedia.org/wiki/Public_holidays_in_Bolivia | |||
There was a problem hiding this comment.
Please leave @attrib inside as we already have used data from there.
|
Hi @jhordyess, |
|
Sure, I'll update the source linking and attributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.