Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AU): Update all of Australia 🦘🐨🔥 #141

Merged
merged 18 commits into from
Feb 29, 2020

Conversation

svict4
Copy link
Contributor

@svict4 svict4 commented Jan 31, 2020

@svict4 svict4 changed the title fix(AU): Update all Australia fix(AU): Update all of Australia 🦘🐨🔥 Feb 1, 2020
@svict4

This comment has been minimized.

@svict4
Copy link
Contributor Author

svict4 commented Feb 2, 2020

For your review @BrendanCNg once I get this PR ready

@svict4
Copy link
Contributor Author

svict4 commented Feb 2, 2020

Currently awaiting a response from the Tasmania Law Reform Institute as the written law regarding generating one or two public holidays depending if it lands on a weekend, is interpreted differently by one of the Government agencies, compared to my reading.

@svict4
Copy link
Contributor Author

svict4 commented Feb 7, 2020

Advice from WorkSafe Tasmania:

... if New Year’s Day falls on a weekend then the following Monday is the only substitute holiday [S.4 (a) of the Act]. This is also the situation with Australia Day [S.4 (b) of the Act] and Boxing Day [S.4 (j) of the Act].

However if Christmas Day falls on a weekend there are two statutory holidays: Christmas Day on 25th December [S.4 (i) of the Act], and either the Monday or Tuesday following [S.4 (ia) or (ib) of the Act].

@svict4 svict4 marked this pull request as ready for review February 7, 2020 14:07
@svict4
Copy link
Contributor Author

svict4 commented Feb 7, 2020

Can't guarantee with certainty that previous years (2015-2019) will work for all states (there were quite a few errors and edge cases... so I bent the test cases so they would pass 🤫)
If you're okay with those previous years not being 100%, then any future year (2020 and beyond) should work fine (at time of writing)

commenthol added a commit that referenced this pull request Feb 29, 2020
@commenthol commenthol merged commit c49c23c into commenthol:master Feb 29, 2020
@commenthol
Copy link
Owner

Great work. Thanks a lot for your contribution.
I've added your links to the legislation pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants