events.py: enhance efficiency of clear() by eliminating full dictionary rebuild #33521
+16
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
clear()
method rebuilds the entire dictionary from the keys inEVENTS
on each call, resulting in inefficient performance. For example, inselfdrived,
clear() is among the top five most time-consuming operations, with its execution time just behindSelfdriveD.publish_selfdriveState(self, CS)
, which is unreasonable:After this PR, the execution time of
clear()
has been reduced from 0.324 to 0.0311, making it approximately 10 times faster. This improvement should enhance the runtime efficiency of both selfdrived and card.Changes: