pre-commit: bring back some checks #33196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime-desroches
changed the title
|
If the first fails, do the rest run? |
|
@sshane Currently not, but I can make it that way if you think it would help your workflow |
maxime-desroches
force-pushed
the
new_pre_commit
branch
from
c28343e
to
7a21ed7
Compare
|
It's fine for now, but would be nice to show a summary like pre-commit later on |
maxime-desroches
added a commit
that referenced
this pull request
Aug 7, 2024
This reverts commit 30467b4.
maxime-desroches
added a commit
that referenced
this pull request
Aug 7, 2024
Edison-CBS
pushed a commit
to Edison-CBS/openpilot
that referenced
this pull request
Sep 15, 2024
* add this * add this * nice ... * 120 * remove * no remote * 0 * this * no submodules * like this * try this * validate * like this * split * pass files * no par * check exist * no build * fix * 24.04 * default * test failure * continue * actually fail * clean * import * fix * line * mypy * clean * simpler * final * better * final clean * not true old-commit-hash: 30467b4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will run the checks against all staged + committed changes since origin/master
adds ruff, mypy, large files, shebang, codespell
can also do cool stuff like
op lint selfdrive/car/honda/*orop lint selfdrive/ui/ui.py