UI: DM icon shows engaged IF always-on

[ugtthis]

Problem: DM icon only shows engaged when openpilot is engaged. DM icon does not show it is engaged if "Always-on driver monitoring" is enabled.

Solution: Make DM Icon show as engaged(with green tracking arcs as shown below) when either openpilot is engaged OR when Always-on driver monitoring is enabled.

DM icon not engaged showing grey tracking arc color

[github-actions]

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

• Convert your PR to a draft unless it's ready to review
• Read the contributing docs
• Before marking as "ready for review", ensure:
  • the goal is clearly stated in the description
  • all the tests are passing
  • the change is something we merge
  • include a route or your device' dongle ID if relevant

[github-actions]

UI Screenshots

[deanlee]

Added some suggestions.

[ugtthis]

Can you repost them? For some reason I don't see any suggestions from you on my end

[FrogAi]

@ugtthis I made a PR to your repo that cleans up the usage of the params.

[ugtthis]

@FrogAi and @deanlee thanks guys for cleaning up my code. Learned a lot thanks!

[sshane]

@ZwX1616 Do we want to keep this engaged-only for any ux reason?

[ZwX1616]

@ZwX1616 Do we want to keep this engaged-only for any ux reason?

Yes green should be consistent with engaged state

[ugtthis]

It still is green when engaged for this PR. But it also gets it to turn green when people toggle the always-on driver monitoring to show that DM is engaged even when openpilot is not engaged. This is to show users clearer when DM is on, and when it is not.

This PR came about when I was driving without openpilot engaged and I was getting DM alerts saying to pay attention and I was confused why, then went to settings and saw I had "Always-On Driver Monitoring" enabled

[ugtthis]

I don’t think users go into settings every time they use openpilot. And currently that would be the only way to check if your “Always-On Driver monitoring” is engaged for the trip.

For people who are using this always-on DM feature when openpilot is not engaged and don’t check their settings every drive, how would they know whether it’s not alerting them to pay attention/wake up because DM is off or whether the DM just needs to get better?