ui: Device to its own file
#32987
Closed
ui: Device to its own file
#32987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
sunnyhaibin
changed the title
Device to its own fileDevice to its own file
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
UI Screenshots
|
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
|
Closing as it's deemed as Negative expected value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split
Deviceclass into its own file underqt/devicedirectory. This keeps functions readable and organized.Similar to #32059